Checkstyle Results
The following document contains the results of
Checkstyle.
Summary
Files | Infos | Warnings | Errors |
80 | 0 | 0 | 285 |
Files
pl/kernelpanic/dbmonster/DBMonster.java
Error | Line |
| First sentence should end with a period. |
136
|
| First sentence should end with a period. |
141
|
| Method 'getConnectionProvider' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Method 'setConnectionProvider' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Method 'addSchema' is not designed for extension - needs to be abstract, final or empty. |
176
|
| Line is longer than 80 characters. |
179
|
| Method 'setLogger' is not designed for extension - needs to be abstract, final or empty. |
189
|
| Method 'getLogger' is not designed for extension - needs to be abstract, final or empty. |
198
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
207
|
| Method 'doTheJob' is not designed for extension - needs to be abstract, final or empty. |
225
|
| Method 'getProgressMonitor' is not designed for extension - needs to be abstract, final or empty. |
315
|
| Method 'setProgressMonitor' is not designed for extension - needs to be abstract, final or empty. |
324
|
| Parameter monitor should be final. |
324
|
| Method 'setPostScript' is not designed for extension - needs to be abstract, final or empty. |
328
|
| Missing a Javadoc comment. |
328
|
| Parameter postScript should be final. |
328
|
| 'postScript' hides a field. |
328
|
| Method 'setPreScript' is not designed for extension - needs to be abstract, final or empty. |
332
|
| Missing a Javadoc comment. |
332
|
| Parameter preScript should be final. |
332
|
| 'preScript' hides a field. |
332
|
| Line is longer than 80 characters. |
336
|
| Missing a Javadoc comment. |
336
|
| Parameter cp should be final. |
336
|
| Parameter scriptFile should be final. |
336
|
pl/kernelpanic/dbmonster/Dictionary.java
Error | Line |
| Redundant 'final' modifier. |
151
|
pl/kernelpanic/dbmonster/DictionaryManager.java
Error | Line |
| Redundant 'final' modifier. |
141
|
| Redundant 'final' modifier. |
167
|
| Redundant 'final' modifier. |
180
|
pl/kernelpanic/dbmonster/Launcher.java
Error | Line |
| Line is longer than 80 characters. |
159
|
| Line is longer than 80 characters. |
165
|
| First sentence should end with a period. |
197
|
| Redundant 'final' modifier. |
203
|
| Redundant 'final' modifier. |
218
|
| Redundant 'final' modifier. |
229
|
| Redundant 'final' modifier. |
248
|
| Line is longer than 80 characters. |
294
|
| Line is longer than 80 characters. |
301
|
pl/kernelpanic/dbmonster/ProgressMonitorAdapter.java
Error | Line |
| Line does not match expected header line of '/* Version 1.0 based on Apache Software License 1.1'. |
1
|
| Missing a Javadoc comment. |
25
|
| Variable 'schemasCount' must be private and have accessor methods. |
25
|
| Missing a Javadoc comment. |
26
|
| Variable 'tablesCount' must be private and have accessor methods. |
26
|
| Missing a Javadoc comment. |
27
|
| Variable 'rowsCount' must be private and have accessor methods. |
27
|
| Missing a Javadoc comment. |
28
|
| Variable 'schemaName' must be private and have accessor methods. |
28
|
| Missing a Javadoc comment. |
29
|
| Variable 'tableName' must be private and have accessor methods. |
29
|
| Line has trailing spaces. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
40
|
| Missing a Javadoc comment. |
43
|
| Method 'setSchemaCount' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter count should be final. |
46
|
| Method 'setTableCount' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter count should be final. |
50
|
| Method 'setRowsCount' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter count should be final. |
54
|
| Missing a Javadoc comment. |
58
|
| Missing a Javadoc comment. |
61
|
| Missing a Javadoc comment. |
64
|
| Method 'setSchemaName' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Parameter name should be final. |
67
|
| Method 'setTableName' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Missing a Javadoc comment. |
71
|
| Parameter name should be final. |
71
|
pl/kernelpanic/dbmonster/SchemaGrabber.java
Error | Line |
| '1000' is a magic number. |
133
|
| First sentence should end with a period. |
141
|
| Must have at least one statement. |
194
|
| '100' is a magic number. |
211
|
| '}' should be on the same line. |
257
|
| First sentence should end with a period. |
365
|
| First sentence should end with a period. |
426
|
| Expected @param tag for 'p'. |
430
|
| Redundant 'final' modifier. |
446
|
| Redundant 'final' modifier. |
501
|
| '10' is a magic number. |
528
|
| Line is longer than 80 characters. |
543
|
| Redundant 'final' modifier. |
592
|
| Line has trailing spaces. |
594
|
| Line has trailing spaces. |
598
|
| Redundant 'final' modifier. |
614
|
| Line has trailing spaces. |
616
|
| Line has trailing spaces. |
620
|
| Redundant 'final' modifier. |
632
|
| Line has trailing spaces. |
634
|
| Line has trailing spaces. |
638
|
| First sentence should end with a period. |
644
|
| Redundant 'final' modifier. |
651
|
| Line has trailing spaces. |
653
|
| Line has trailing spaces. |
657
|
| First sentence should end with a period. |
678
|
| Redundant 'final' modifier. |
694
|
| Redundant 'final' modifier. |
703
|
| Redundant 'final' modifier. |
712
|
| First sentence should end with a period. |
716
|
| Redundant 'final' modifier. |
721
|
pl/kernelpanic/dbmonster/connection/DBCPConnectionProvider.java
Error | Line |
| Line is longer than 80 characters. |
80
|
| Must have at least one statement. |
221
|
| Redundant 'final' modifier. |
239
|
| Redundant 'final' modifier. |
248
|
pl/kernelpanic/dbmonster/connection/SimpleConnectionProvider.java
Error | Line |
| Line is longer than 80 characters. |
73
|
| Redundant 'final' modifier. |
212
|
pl/kernelpanic/dbmonster/connection/Transaction.java
Error | Line |
| Must have at least one statement. |
136
|
| Line has trailing spaces. |
137
|
| Must have at least one statement. |
148
|
| Line has trailing spaces. |
149
|
| Must have at least one statement. |
158
|
| Line has trailing spaces. |
159
|
| Must have at least one statement. |
168
|
| Line has trailing spaces. |
169
|
| Must have at least one statement. |
178
|
| Line has trailing spaces. |
179
|
pl/kernelpanic/dbmonster/generator/BasicDataGenerator.java
Error | Line |
| Unclosed HTML tag found: <piotr.maj@kernelpanic.pl> |
55
|
| Variable 'nulls' must be private and have accessor methods. |
64
|
| Variable 'column' must be private and have accessor methods. |
69
|
| Method 'setColumn' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| Method 'getNulls' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Method 'setNulls' is not designed for extension - needs to be abstract, final or empty. |
98
|
pl/kernelpanic/dbmonster/generator/BooleanGenerator.java
Error | Line |
| Line is longer than 80 characters. |
62
|
| '50' is a magic number. |
67
|
| '101' is a magic number. |
94
|
| '101' is a magic number. |
98
|
pl/kernelpanic/dbmonster/generator/ConstantGenerator.java
Error | Line |
| Line has trailing spaces. |
63
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Method 'getConstant' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Method 'setConstant' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Parameter constant should be final. |
89
|
| 'constant' hides a field. |
89
|
pl/kernelpanic/dbmonster/generator/DateTimeGenerator.java
Error | Line |
| Line is longer than 80 characters. |
67
|
| '101' is a magic number. |
133
|
| Redundant 'final' modifier. |
235
|
| '10' is a magic number. |
240
|
| '16' is a magic number. |
243
|
| '19' is a magic number. |
246
|
| '23' is a magic number. |
249
|
pl/kernelpanic/dbmonster/generator/DictionaryGenerator.java
Error | Line |
| Line is longer than 80 characters. |
86
|
pl/kernelpanic/dbmonster/generator/ForeignKeyGenerator.java
Error | Line |
| Line is longer than 80 characters. |
74
|
| First sentence should end with a period. |
116
|
pl/kernelpanic/dbmonster/generator/KeyGenerator.java
Error | Line |
| First sentence should end with a period. |
69
|
| Expected an @return tag. |
72
|
pl/kernelpanic/dbmonster/generator/MaxKeyGenerator.java
Error | Line |
| Method 'setKey' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Missing a Javadoc comment. |
100
|
| Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
127
|
pl/kernelpanic/dbmonster/generator/NumberGenerator.java
Error | Line |
| Line is longer than 80 characters. |
62
|
| '101' is a magic number. |
142
|
pl/kernelpanic/dbmonster/generator/StringGenerator.java
Error | Line |
| Line is longer than 80 characters. |
92
|
| Line is longer than 80 characters. |
97
|
| '255' is a magic number. |
107
|
| Line is longer than 80 characters. |
143
|
| '101' is a magic number. |
161
|
pl/kernelpanic/dbmonster/generator/StringKeyGenerator.java
Error | Line |
| '26' is a magic number. |
107
|
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Missing a Javadoc comment. |
123
|
| Redundant 'final' modifier. |
244
|
| First sentence should end with a period. |
273
|
pl/kernelpanic/dbmonster/schema/Column.java
Error | Line |
| First sentence should end with a period. |
198
|
| Method 'getTargetType' is not designed for extension - needs to be abstract, final or empty. |
254
|
| Method 'setTargetType' is not designed for extension - needs to be abstract, final or empty. |
260
|
| Parameter targetType should be final. |
260
|
| 'targetType' hides a field. |
260
|
pl/kernelpanic/dbmonster/schema/Key.java
Error | Line |
| First sentence should end with a period. |
173
|
pl/kernelpanic/dbmonster/schema/Schema.java
Error | Line |
| Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
125
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
134
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Method 'getHome' is not designed for extension - needs to be abstract, final or empty. |
193
|
| Method 'setHome' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Method 'findTable' is not designed for extension - needs to be abstract, final or empty. |
213
|
| Method 'getTables' is not designed for extension - needs to be abstract, final or empty. |
222
|
| Method 'removeTable' is not designed for extension - needs to be abstract, final or empty. |
237
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
245
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
253
|
pl/kernelpanic/dbmonster/schema/SchemaUtil.java
Error | Line |
| Redundant 'final' modifier. |
175
|
| Line has trailing spaces. |
179
|
| Missing a Javadoc comment. |
180
|
| Redundant 'final' modifier. |
180
|
| Redundant 'final' modifier. |
203
|
| Redundant 'final' modifier. |
219
|
| Line is longer than 80 characters. |
224
|
| Missing a Javadoc comment. |
224
|
| Redundant 'final' modifier. |
224
|
| Redundant 'final' modifier. |
229
|
| Redundant 'final' modifier. |
234
|
| Redundant 'final' modifier. |
239
|
| Redundant 'final' modifier. |
299
|
| Redundant 'final' modifier. |
329
|
| Redundant 'final' modifier. |
366
|
| Redundant 'final' modifier. |
386
|
| Redundant 'final' modifier. |
410
|
| '3' is a magic number. |
433
|
| Redundant 'final' modifier. |
457
|
| Redundant 'final' modifier. |
489
|
| Redundant 'final' modifier. |
524
|
| Redundant 'final' modifier. |
553
|
| Redundant 'final' modifier. |
573
|
| Redundant 'final' modifier. |
595
|
| Redundant 'final' modifier. |
634
|
| Redundant 'final' modifier. |
657
|
pl/kernelpanic/dbmonster/schema/Table.java
Error | Line |
| '1000L' is a magic number. |
120
|
| Missing a Javadoc comment. |
173
|
| Line is longer than 80 characters. |
188
|
| Line is longer than 80 characters. |
239
|
| Line is longer than 80 characters. |
249
|
| Line is longer than 80 characters. |
253
|
| Line is longer than 80 characters. |
259
|
| Line is longer than 80 characters. |
273
|
| Line is longer than 80 characters. |
326
|
| Line is longer than 80 characters. |
341
|
| Line is longer than 80 characters. |
384
|
| Line is longer than 80 characters. |
385
|
| Line is longer than 80 characters. |
387
|
| Line is longer than 80 characters. |
389
|
| Line is longer than 80 characters. |
391
|
| Line is longer than 80 characters. |
400
|
| Line is longer than 80 characters. |
401
|
| Line is longer than 80 characters. |
403
|
| Line is longer than 80 characters. |
405
|
| Line is longer than 80 characters. |
418
|
| Line is longer than 80 characters. |
423
|
| Line has trailing spaces. |
428
|
| Line is longer than 80 characters. |
441
|
| Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
537
|
| Missing a Javadoc comment. |
537
|
| Parameter name should be final. |
537
|
| 'name' hides a field. |
537
|
| Method 'findColumn' is not designed for extension - needs to be abstract, final or empty. |
547
|
| Missing a Javadoc comment. |
547
|
| Parameter name should be final. |
547
|
| 'name' hides a field. |
547
|
pl/kernelpanic/dbmonster/sql/ExtendedTypes.java
Error | Line |
| Class ExtendedTypes should be declared as final. |
59
|
| Name 'single' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
64
|
| Line has trailing spaces. |
70
|
| First sentence should end with a period. |
71
|
| Line has trailing spaces. |
76
|
| Line has trailing spaces. |
80
|
| '-9' is a magic number. |
82
|
| Line has trailing spaces. |
105
|
| 'if' construct must use '{}'s. |
109
|
| Line has trailing spaces. |
119
|
| Line has trailing spaces. |
129
|
| 'if' construct must use '{}'s. |
134
|
pl/kernelpanic/dbmonster/sql/package.html
Error | Line |
| Missing package documentation file. | 0 |
pl/kernelpanic/dbmonster/util/Converter.java
Error | Line |
| Redundant 'final' modifier. |
72
|
| '3600000' is a magic number. |
77
|
| '3600000' is a magic number. |
82
|
| '60000' is a magic number. |
85
|
| '60000' is a magic number. |
92
|
| '1000' is a magic number. |
95
|
| '1000' is a magic number. |
102
|
| First sentence should end with a period. |
120
|
| Redundant 'final' modifier. |
127
|
| '100' is a magic number. |
128
|
| '100' is a magic number. |
131
|
| '100' is a magic number. |
132
|
pl/kernelpanic/dbmonster/util/ScriptReaderIterator.java
Error | Line |
| Line does not match expected header line of '/* Version 1.0 based on Apache Software License 1.1'. |
1
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
37
|
| Parameter script should be final. |
37
|
| Missing a Javadoc comment. |
42
|
| Parameter reader should be final. |
42
|
| 'reader' hides a field. |
42
|
| Missing a Javadoc comment. |
47
|
| Parameter file should be final. |
47
|
| Line is longer than 80 characters. |
48
|
| Missing a Javadoc comment. |
52
|
| Method 'hasNext' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Missing a Javadoc comment. |
55
|
| Method 'next' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Missing a Javadoc comment. |
59
|
| Missing a Javadoc comment. |
65
|